Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2.2.3 into develop #5134

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Merge 2.2.3 into develop #5134

merged 3 commits into from
Sep 16, 2024

Conversation

intelliot
Copy link
Collaborator

High Level Overview of Change

Merge 2.2.3 hotfix release into develop.

Context of Change

Set max_page_count=4294967294 to provide more headroom for full history servers using transaction.db.

Type of Change

  • Release

jscottbranson and others added 3 commits September 14, 2024 11:38
When rippled initiates a connection to SQLite3, rippled sends a "PRAGMA"
statement defining the maximum number of pages allowed in the database.
Update the max_page_count so it is consistent with the default for newer
versions of SQLite3. Increasing max_page_count is critical for keeping
full history servers online.

Fix XRPLF#5102
@intelliot intelliot mentioned this pull request Sep 15, 2024
1 task
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.2%. Comparing base (23991c9) to head (fa1cbb0).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5134     +/-   ##
=========================================
+ Coverage     76.1%   76.2%   +0.1%     
=========================================
  Files          760     760             
  Lines        61548   61548             
  Branches      8159    8160      +1     
=========================================
+ Hits         46836   46869     +33     
+ Misses       14712   14679     -33     
Files with missing lines Coverage Δ
src/libxrpl/protocol/BuildInfo.cpp 98.1% <ø> (ø)

... and 8 files with indirect coverage changes

Impacted file tree graph

@Bronek Bronek self-requested a review September 16, 2024 12:53
Copy link
Collaborator

@Bronek Bronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is faithful to release 2.2.3

@XRPLF XRPLF deleted a comment from Speedtraders48 Sep 16, 2024
@XRPLF XRPLF deleted a comment from Speedtraders48 Sep 16, 2024
@intelliot intelliot merged commit fa1cbb0 into XRPLF:develop Sep 16, 2024
22 checks passed
@intelliot intelliot deleted the develop-next branch September 16, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants